From d8f88300dd320e00c52a7b38d92d29481b3d2a38 Mon Sep 17 00:00:00 2001 From: nick-place-lob Date: Tue, 7 May 2024 14:23:51 -0500 Subject: [PATCH 1/5] update deprecated github actions --- .github/workflows/run_tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index 0eb0ad1..4cfc088 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -14,11 +14,11 @@ jobs: dotnet-version: ['3.1.x'] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: dotnet-version: ${{ matrix.dotnet-version }} - name: Setup .NET Core SDK ${{ matrix.dotnet-version }} - uses: actions/setup-dotnet@v2 + uses: actions/setup-dotnet@v4 with: dotnet-version: ${{ matrix.dotnet-version }} - name: Install dependencies From d6f6841751655a18fca8c9fcc6bcae8176927473 Mon Sep 17 00:00:00 2001 From: nick-place-lob Date: Tue, 7 May 2024 14:57:50 -0500 Subject: [PATCH 2/5] can't use dotnet-version for actions/checkout --- .github/workflows/run_tests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index 4cfc088..e63d40a 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -15,8 +15,6 @@ jobs: steps: - uses: actions/checkout@v4 - with: - dotnet-version: ${{ matrix.dotnet-version }} - name: Setup .NET Core SDK ${{ matrix.dotnet-version }} uses: actions/setup-dotnet@v4 with: From 6fb1fc59289b3030dc9b2a4b7579fbbffbcbdfc1 Mon Sep 17 00:00:00 2001 From: nick-place-lob Date: Tue, 7 May 2024 15:11:27 -0500 Subject: [PATCH 3/5] remove line, kick off GHA --- .github/workflows/run_tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index e63d40a..dac6125 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -28,4 +28,3 @@ jobs: env: LOB_API_TEST_KEY: ${{ secrets.LOB_API_TEST_KEY }} LOB_API_LIVE_KEY: ${{ secrets.LOB_API_LIVE_KEY }} - From 70686a26e13244fb00f8e86c6a649954d9118a0d Mon Sep 17 00:00:00 2001 From: nick-place-lob Date: Tue, 7 May 2024 15:16:52 -0500 Subject: [PATCH 4/5] run tests for any branch --- .github/workflows/run_tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index dac6125..30f431f 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -4,7 +4,7 @@ on: pull_request: types: [opened, reopened, edited] branches: - - main + - '*' jobs: build: From f490c40561d51ad15aedeff249806f39e725b5b7 Mon Sep 17 00:00:00 2001 From: nick-place-lob Date: Tue, 7 May 2024 15:20:27 -0500 Subject: [PATCH 5/5] trigger tests off ready_for_review on PRs --- .github/workflows/run_tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index 30f431f..c1fa039 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -2,9 +2,9 @@ name: Run Tests on: pull_request: - types: [opened, reopened, edited] + types: [opened, reopened, edited, ready_for_review] branches: - - '*' + - main jobs: build: