Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CheckEditable.amount from Float to Double #346

Open
mccormick-wooden opened this issue Nov 19, 2024 · 0 comments
Open

Change CheckEditable.amount from Float to Double #346

mccormick-wooden opened this issue Nov 19, 2024 · 0 comments

Comments

@mccormick-wooden
Copy link

mccormick-wooden commented Nov 19, 2024

Float too imprecise for this field, and when serialized the value can materially change:

jshell> 147480.18f
$1 ==> 147480.19

We should at least change the type to Double, though I would prefer to change this field to BigDecimal - let me know if that is workable (not sure why floating point types were originally chosen for this and understand there may be constraints I'm not aware of).

Fix attempted here: #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant