Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook_delete #52

Open
ekes opened this issue May 6, 2021 · 0 comments
Open

Add hook_delete #52

ekes opened this issue May 6, 2021 · 0 comments

Comments

@ekes
Copy link
Member

ekes commented May 6, 2021

Background:

Additional context:

It is normal in Drupal to not update the entities that are referencing an item that is deleted. The expectation is on any code using the list to check that they still exist. I remember it's tripped up Search API several times. There's a core issue to alter this behaviour https://www.drupal.org/project/drupal/issues/2723323

Task:

So despite the tests now passing as we are checking referenced entities exist before using them; but because we are handling updates, and core would like to handle deletions in the future. For consistency, we should add a hook_delete that corrects the overview/page entity references on deletion. This could offer the opportunity to remove all pages if the overview is deleted for example?

@ekes ekes mentioned this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant