From d092242c7336a532b7b0cda141f3fb6337da0338 Mon Sep 17 00:00:00 2001 From: Cornelius Roemer Date: Thu, 29 Aug 2024 00:59:43 +0200 Subject: [PATCH] Adress review comments --- ingest/scripts/group_segments.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ingest/scripts/group_segments.py b/ingest/scripts/group_segments.py index a42e8a80d..2e129556a 100644 --- a/ingest/scripts/group_segments.py +++ b/ingest/scripts/group_segments.py @@ -109,11 +109,11 @@ def main( # These are the fields that are expected to be identical across all segments for a given isolate # Dynamically determine the fields that are present in the metadata - some_row = next(iter(segment_metadata.values())) - if not some_row: + first_row = next(iter(segment_metadata.values())) + if not first_row: msg = "No data found in metadata file" raise ValueError(msg) - all_fields = sorted(some_row.keys()) + all_fields = sorted(first_row.keys()) logger.debug(f"All metadata fields: {all_fields}") # Metadata fields can vary between segments w/o indicating being from different assemblies @@ -134,7 +134,7 @@ def main( equivalence_classes: EquivalenceClasses = defaultdict(lambda: defaultdict(list)) for accession, values in segment_metadata.items(): - # Author order sometimes among segments from same isolate + # Author order sometimes varies among segments from same isolate # Example: JX999734.1 (L) and JX999735.1 (M) modified_values = values_with_sorted_authors(values) group_key = str(