Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "noscale" argument #4

Open
Haoxiang-Wang opened this issue Feb 6, 2023 · 1 comment
Open

Remove "noscale" argument #4

Haoxiang-Wang opened this issue Feb 6, 2023 · 1 comment

Comments

@Haoxiang-Wang
Copy link

feature_dataset = FeatureDataset(is_train, image_encoder, dataset, args.device, args.cache_dir, args.noscale)

It seems the noscale argument is useless in this codebase, and the non-existence of args.noscale incurs errors. So it's better to remove all occurrences of noscale and args.noscale in src/datasets/common.py.

@SachinG007
Copy link
Collaborator

Hi @Haoxiang-Wang ,
Thanks a lot for pointing this out. noscale argument was for some experiments I was doing initially to compare normalizing features with not normalizing them. I will update the codebase and remove this argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants