You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like the best fixed-point estimate z_star = lowest_xest is only returned when the indexed trajectory is empty.
When one specifies indexing, they are not getting the best fixed-point estimate.
# Store the solution at the specified indexifindexingand (nstep+1) inindexing:
indexing_list.append(lowest_xest)
# ...# at least return the lowest value when enabling ``indexing''ifindexingandnotindexing_list:
indexing_list.append(lowest_xest)
info=solver_stat_from_info(stop_mode, lowest_dict, trace_dict, lowest_step_dict)
returnlowest_xest, indexing_list, info
Note that the best fixed-point estimate z_star = lowest_xest is ignored in DEQIndexing
_, trajectory, info=self._solve_fixed_point()
Example
If solver nstep > indexing, lowest_xest is added to trajectory.
Only if nothing was added to the trajectory, lowest_xest is added.
Which means that the trajectory sometimes contains the best fixed-point estimate lowest_xest and sometimes not?
Scenario 1: indexing=[8], nstep=5 -> trajectory contains fp_5
Scenario 2: indexing=[8], nstep=10 -> trajectory contains fp_8
Shouldn't the trajectory contain [fp_5, fp_8] (assuming fp_8 is the better estimate)?
Note that indexing defaults to indexing=[f_max_iter] if not specified otherwise and the best fixed-point estimate is added to the trajectory. So the problem only arises if one specifies indexing or n_states, e.g. to implement the fixed-point correction loss.
It is also not a problem in DEQSliced
The text was updated successfully, but these errors were encountered:
It seems like the best fixed-point estimate
z_star = lowest_xest
is only returned when the indexed trajectory is empty.When one specifies
indexing
, they are not getting the best fixed-point estimate.Relevant Code
From the Broyden solver
Note that the best fixed-point estimate
z_star = lowest_xest
is ignored in DEQIndexingExample
If solver nstep > indexing,
lowest_xest
is added to trajectory.Only if nothing was added to the trajectory,
lowest_xest
is added.Which means that the trajectory sometimes contains the best fixed-point estimate
lowest_xest
and sometimes not?Scenario 1: indexing=[8], nstep=5 -> trajectory contains fp_5
Scenario 2: indexing=[8], nstep=10 -> trajectory contains fp_8
Shouldn't the trajectory contain [fp_5, fp_8] (assuming fp_8 is the better estimate)?
Note that indexing defaults to
indexing=[f_max_iter]
if not specified otherwise and the best fixed-point estimate is added to the trajectory. So the problem only arises if one specifiesindexing
orn_states
, e.g. to implement the fixed-point correction loss.It is also not a problem in DEQSliced
The text was updated successfully, but these errors were encountered: