From 0b4cae7af01f59fc9a005d0d8b3fff4d0096205c Mon Sep 17 00:00:00 2001 From: Kurt Madel Date: Fri, 21 Feb 2025 16:43:49 -0500 Subject: [PATCH 1/3] Update nodes.mdx Fix typo - repeated 'nodes' twice --- vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx b/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx index 19fab7376..d405b2218 100644 --- a/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx +++ b/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx @@ -67,7 +67,7 @@ sync: ### Sync pseudo nodes with label selector -Sync pseudo nodes nodes that match a given label selector. This example sets the node selector to the same values when syncing a pod from virtual cluster to host cluster: +Sync pseudo nodes that match a given label selector. This example sets the node selector to the same values when syncing a pod from virtual cluster to host cluster: ```YAML sync: fromHost: @@ -81,7 +81,7 @@ sync: ### Sync real nodes with label selector -Sync real nodes nodes that match a given label selector. This example sets the node selector to the same values when syncing a pod from virtual cluster to host cluster: +Sync real nodes that match a given label selector. This example sets the node selector to the same values when syncing a pod from virtual cluster to host cluster: ```YAML sync: fromHost: From a0162026e14e39b71302e55c3a997e84b2696e28 Mon Sep 17 00:00:00 2001 From: Kurt Madel Date: Fri, 21 Feb 2025 17:17:11 -0500 Subject: [PATCH 2/3] Update nodes.mdx --- vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx b/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx index d405b2218..461958117 100644 --- a/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx +++ b/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx @@ -10,7 +10,7 @@ import SyncNodes from '../../../../_partials/config/sync/fromHost/nodes.mdx' {/* `nodes.enabled`: - covered by the generic section here: https://www.vcluster.com/docs/syncer/config#enable-or-disable-synced-resources -- exists from the beginning. I believe one would need this to schedule any pods +- exists from the beginning. This is needed to schedule any pods - may be possible to disable this in the "control plane" vCluster when using [Isolated Control Plane](https://www.vcluster.com/pro/docs/features/isolated_control_planes), where all the workloads are scheduled to the workload cluster (where nodes syncing would be enabled) `nodes.syncBackChanges`: @@ -26,12 +26,12 @@ import SyncNodes from '../../../../_partials/config/sync/fromHost/nodes.mdx' - sets `--sync-all-nodes` syncer flag, see also [Example: Sync All Nodes](https://www.vcluster.com/docs/architecture/nodes#example-sync-all-nodes) `nodes.selector.labels`: -- selects node labels that will be synced to the vCluster. This allows controlling which nodes can be used by the vCluste +- selects node labels that are synced to the vCluster. This allows controlling which nodes can be used by the vCluste - Some example use cases: - only allow nodes in a region - only allow nodes with a particular architecture - only use spot instances - - prevent vClusters from sharing resources with critical infrastructure + - prevent vCluster from sharing resources with critical infrastructure */} By default, this is disabled. @@ -40,7 +40,7 @@ vCluster syncs psuedo nodes from the host cluster where there are virtual cluste However, when you need to access specific node information, you can choose to sync real nodes from the host cluster to the virtual cluster. This requires a cluster role. -### Sync pseudo nodes (Default) +### Sync pseudo nodes (default) Sync pseudo nodes to the virtual cluster. This default configuration does not require a cluster role. From c1c48ed7bc6315d1c5acc2adea50f77c04a2db26 Mon Sep 17 00:00:00 2001 From: Joan E <153745173+joaniekube@users.noreply.github.com> Date: Mon, 24 Feb 2025 09:23:52 -0500 Subject: [PATCH 3/3] update typo --- vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx b/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx index 461958117..90ea99bea 100644 --- a/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx +++ b/vcluster/configure/vcluster-yaml/sync/from-host/nodes.mdx @@ -26,8 +26,8 @@ import SyncNodes from '../../../../_partials/config/sync/fromHost/nodes.mdx' - sets `--sync-all-nodes` syncer flag, see also [Example: Sync All Nodes](https://www.vcluster.com/docs/architecture/nodes#example-sync-all-nodes) `nodes.selector.labels`: -- selects node labels that are synced to the vCluster. This allows controlling which nodes can be used by the vCluste -- Some example use cases: +- selects specific node labels to sync with the vCluster. This allows control over which nodes the vCluster can use. +- some example use cases include: - only allow nodes in a region - only allow nodes with a particular architecture - only use spot instances