Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getFieldValue() is not accessible #991

Open
diegomarquezp opened this issue Oct 3, 2023 · 2 comments
Open

getFieldValue() is not accessible #991

diegomarquezp opened this issue Oct 3, 2023 · 2 comments

Comments

@diegomarquezp
Copy link

Hello, since 7.1 we are having issues in our test code that deals with getFieldValue() (tracked in GoogleCloudPlatform/spring-cloud-gcp#1764). This method was declared protected in #720 , apparently only intended to change the return type of this method. Is it possible to change it back to public?

Thank you!

@philsttr
Copy link
Collaborator

philsttr commented Oct 3, 2023

Hi @diegomarquezp

The marker classes are not currently designed to be consumed outside of logstash-logback-encoder. Backwards compatibility is not guarenteed for them. They are public only because the library needs to access them from a different package (net.logstash.logback.argument) for structured arguments.

Can you provide some more details about why you need to access them?

@david0
Copy link

david0 commented May 2, 2024

At least we are using them in unittests too, to see if some MDC fields have been logged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants