Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions not preserved in a JAR within a ZIP #255

Open
mrpegman opened this issue Jan 20, 2022 · 2 comments
Open

Permissions not preserved in a JAR within a ZIP #255

mrpegman opened this issue Jan 20, 2022 · 2 comments
Assignees
@xeraph
Labels
bug Something isn't working

Comments

@mrpegman
Copy link

If you have a JAR with the targeted classes and that JAR is within a ZIP, then scanning the ZIP will remove permissions on the files within the JAR. This is a UNIX-only issue as far as I can tell. Opening up the JAR after scanning shows that the HOST OS was changed from UNIX to FAT and the UNIX-style permissions were stripped.
@xeraph
Copy link
Contributor

xeraph commented Jan 20, 2022 •
edited
Loading

You would have used fix option. Scanner does not modify any file while scanning.

@xeraph xeraph self-assigned this Jan 20, 2022
@xeraph xeraph added the discussion question or suggestion label Jan 20, 2022
@mrpegman
Copy link
Author

The command that I ran was: java -jar esp.jar --scan-log4j1 --scan-zip --fix fsc.zip

The esp.jar is the logpresso JAR. The fsc.zip file contains a JAR which when it gets scanned has the UNIX file permissions removed.

@xeraph xeraph added bug Something isn't working and removed discussion question or suggestion labels Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xeraph xeraph

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xeraph @mrpegman