-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support macOS and/or Windows? #4
Comments
That would be most welcome. But note that only installing on Windows is currently unsupported. Or did you found an issue with macOS install? |
I didn't see where you were installing on macOS. Plus, there's this: setup-swi-prolog/src/setup-swi-prolog.js Line 22 in 73687be
|
Indeed. I was looking into the wrong action! Sorry about that. |
Looking into this more, it seems like the current approach of this action makes things a bit more complicated for macOS and Windows if you want to support the same flexibility. You allow the user to select Current statusmacOSI currently get The package for a selected version can be installed from https://www.swi-prolog.org/download/devel/bin/ or https://www.swi-prolog.org/download/stable/bin/. WindowsI currently get The package for a selected version can also be installed from https://www.swi-prolog.org/download/devel/bin/ or https://www.swi-prolog.org/download/stable/bin/. Potential version/platform issueI'm not sure if there are cases where the requested version might be different for different platforms. For example, one platform has a AlternativesMacPortsMacPorts provides a Website scrapingWe could scrape the SWI-Prolog downloads pages to determine the latest Ask for helpWe could ask the SWI-Prolog maintainers to help by providing a link (say, on https://www.swi-prolog.org/) that is always updated to refer to the latest macOS and Windows Simplify the actionWe could simplify in different ways:
However the installation is done, I think it best to be consistent about the source. That is, I don't think it's a good idea, for example, to get the macOS What are your thoughts? |
It seems that installing macOS packages (which would be downloaded from either https://www.swi-prolog.org/download/devel/bin/ or https://www.swi-prolog.org/download/stable/bin/) unattended is possible: https://apple.stackexchange.com/questions/113489/unattended-installation-of-pkg-file#113498 Assuming the same is true for the Windows installers, this would give parity with the Ubuntu installation options ("devel" and "stable"). Still, at least in the case of macOS, this will also require updating the |
Thanks! I assumed that it was possible on macOS, because I know Homebrew does it with casks, and that it was possible on Windows, because Chocolatey does it, but I have not yet looked into the actual mechanism. If you think the right way to go is to use the packaged releases from https://www.swi-prolog.org, how should we resolve which version to use for |
The main reason to go for the packaged releases from https://www.swi-prolog.org would be to avoid compiling from sources, which could force us to deal with necessary dependencies that may or may not be installed. It should also provide better setup performance. As you mention, the main issue seems to be how to find which version (from stable or devel directories), is the latest. A possible solution would be for the |
It's great to see this action! I was thinking about doing something similar myself.
I recently did some work getting SWI Prolog to install on macOS and Windows. Would you be willing to accept pull requests for these? Then I could use this action instead of my scripts.
The text was updated successfully, but these errors were encountered: