[cleanup] don't await in a couple places where we don't need to (#1583)

was looking at generated code and saw that we were awaiting and checking null here when we don't need to since the value is typed correctly
lolopinto · Aug 7, 2023 · 93987f6 · 93987f6
1 parent 98c6b68
commit 93987f6
Show file tree

Hide file tree

Showing 18 changed files with 23 additions and 117 deletions.
diff --git a/examples/ent-rsvp/backend/src/ent/generated/address_base.ts b/examples/ent-rsvp/backend/src/ent/generated/address_base.ts
diff --git a/examples/ent-rsvp/backend/src/ent/generated/auth_code_base.ts b/examples/ent-rsvp/backend/src/ent/generated/auth_code_base.ts
diff --git a/examples/ent-rsvp/backend/src/ent/generated/event_activity_base.ts b/examples/ent-rsvp/backend/src/ent/generated/event_activity_base.ts
diff --git a/examples/ent-rsvp/backend/src/ent/generated/event_base.ts b/examples/ent-rsvp/backend/src/ent/generated/event_base.ts
diff --git a/examples/ent-rsvp/backend/src/ent/generated/guest_base.ts b/examples/ent-rsvp/backend/src/ent/generated/guest_base.ts
diff --git a/examples/ent-rsvp/backend/src/ent/generated/guest_data_base.ts b/examples/ent-rsvp/backend/src/ent/generated/guest_data_base.ts
diff --git a/examples/ent-rsvp/backend/src/ent/generated/guest_group_base.ts b/examples/ent-rsvp/backend/src/ent/generated/guest_group_base.ts
diff --git a/examples/ent-rsvp/backend/src/ent/generated/user_base.ts b/examples/ent-rsvp/backend/src/ent/generated/user_base.ts
diff --git a/examples/simple/src/ent/generated/address_base.ts b/examples/simple/src/ent/generated/address_base.ts
diff --git a/examples/simple/src/ent/generated/auth_code_base.ts b/examples/simple/src/ent/generated/auth_code_base.ts
diff --git a/examples/simple/src/ent/generated/comment_base.ts b/examples/simple/src/ent/generated/comment_base.ts
diff --git a/examples/simple/src/ent/generated/contact_base.ts b/examples/simple/src/ent/generated/contact_base.ts
diff --git a/examples/simple/src/ent/generated/contact_email_base.ts b/examples/simple/src/ent/generated/contact_email_base.ts
diff --git a/examples/simple/src/ent/generated/contact_phone_number_base.ts b/examples/simple/src/ent/generated/contact_phone_number_base.ts
diff --git a/examples/simple/src/ent/generated/event_base.ts b/examples/simple/src/ent/generated/event_base.ts
diff --git a/examples/simple/src/ent/generated/holiday_base.ts b/examples/simple/src/ent/generated/holiday_base.ts
diff --git a/examples/simple/src/ent/generated/hours_of_operation_base.ts b/examples/simple/src/ent/generated/hours_of_operation_base.ts
diff --git a/internal/tscode/base.tmpl b/internal/tscode/base.tmpl
@@ -341,11 +341,7 @@ implements {{useImport "Ent"}}<{{$viewerType}}>
     id: ID,
     context?: {{useImport "Context"}},
   ): Promise<{{$rawDBDataType}} | null> {
-    const row = await {{useImport $loaderName}}.createLoader(context).load(id);
-    if (!row) {
-      return null;
-    }
-    return row;
+    return {{useImport $loaderName}}.createLoader(context).load(id);
   }
 
   static async loadRawDataX<T extends {{$baseClass}}>(
@@ -408,11 +404,7 @@ implements {{useImport "Ent"}}<{{$viewerType}}>
         {{$field.TsFieldName $cfg}}: {{$field.GetNotNullableTsType}},
         context?: {{useImport "Context"}},
       ): Promise<{{$rawDBDataType}} | null> {
-        const row = await {{$fieldLoader}}.createLoader(context).load({{$field.TsFieldName $cfg}});
-        if (!row) {
-          return null;
-        }
-        return row;
+        return {{$fieldLoader}}.createLoader(context).load({{$field.TsFieldName $cfg}});
       }
     {{ else if $field.QueryFromEnt -}}
       {{$queryName := useImport ($this.GetFieldQueryName $field) -}}