Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns should create GraphQL Interfaces instead of Unions #1832

Open
Swahvay opened this issue Sep 6, 2024 · 0 comments
Open

Patterns should create GraphQL Interfaces instead of Unions #1832

Swahvay opened this issue Sep 6, 2024 · 0 comments

Comments

@Swahvay
Copy link
Contributor

Swahvay commented Sep 6, 2024

Patterns create unions in graphQL which is technically valid and correct, but not really useful the way patterns are implemented in Ent. They should be interfaces, and then the ents that use those patterns would implement the interfaces. This would allow the more common use case of typing a graphQL query to a pattern. E.g.,

node(id: '...') {
  ... on ProfilePattern {
    profilePicture
  }
}

Instead of having to do

node(id: '...') {
  ... on User {
    profilePicture
  }
  ... on Business {
    profilePicture
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant