cleanup NodeInstance in generated code #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's annoying, have had to clean it up/maintain it as we support different types use "obj" consistently instead of trying to map it to the type of ent this also fixes a weird bug if a separate object was defined in another file e.g. `EmailInfoType` in `contact_type.ts` where the NodeInstance value wasn't consistent because the file is passing "contact" and the code was expecting "obj" the types are currently defined in the base ent file if they are returned from a custom field in that. it's just sadness over time as things changed/evolved/haven't been cleaned up yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's annoying, have had to clean it up/maintain it as we support different types use "obj" consistently instead of trying to map it to the type of ent
this also fixes a weird bug if a separate object was defined in another file and has a field whose graphql name is different from the field name e.g.
EmailInfoType.firstNameincontact_type.tswhere the NodeInstance value wasn't consistent because the file is passing "contact" and the code was expecting "obj"the types are currently defined in the base ent file if they are returned from a custom field in that.
it's just sadness over time as things changed/evolved/haven't been cleaned up yet.