Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the world to create a Pull Request for adding a sub domain #1

Open
florent-pasquer-needone opened this issue Jun 19, 2020 · 3 comments
Open

Allow the world to create a Pull Request for adding a sub domain #1

florent-pasquer-needone opened this issue Jun 19, 2020 · 3 comments
Assignees
@williamdes
Labels
enhancement New feature or request

Comments

@florent-pasquer-needone
Copy link

florent-pasquer-needone commented Jun 19, 2020 •
edited
Loading

It will be nice to be able to create a Pull Request for adding a sub-domain.

Exemple :

PR for adding the sub-domain stade-rennais.long-term.support
@wdes-bot wdes-bot added the enhancement New feature or request label Jun 19, 2020
@williamdes
Copy link
Contributor

I agree, I will have to setup a GitHub action for that and add the secrets to this repo.

@williamdes williamdes self-assigned this Jun 19, 2020
@florent-pasquer-needone
Copy link
Author

florent-pasquer-needone commented Jun 19, 2020 •
edited
Loading

Why not to permit this directly (now) for the end-user ?

The internal logic (automation or not) is a 2nd phasis :)

@williamdes
Copy link
Contributor

Well the fact is that I can not give access to editing our DNS and other settings on my Cloudflare dashboard.

But I can have a list of subdomains or a domain mapping in a JSON file and allow anyone to edit it here.
After approval a GitHub action would apply the changes on the DNS table.

Does this solution look good ?

@williamdes williamdes changed the title Allow the word to create a Pull Request for adding a sub domain Allow the world to create a Pull Request for adding a sub domain Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamdes williamdes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@williamdes @florent-pasquer-needone @wdes-bot