Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial disabling any other action granting perks #1661

Open
wdanny69 opened this issue Feb 3, 2024 · 1 comment
Open

Serial disabling any other action granting perks #1661

wdanny69 opened this issue Feb 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@wdanny69
Copy link
Collaborator

wdanny69 commented Feb 3, 2024

Issue: When Serial is active, it disables some action granting perks that do not trigger upon kill (tested hit n run and close encounters) and will not grant any actions.

Expected behavior: the expectation should be that serial will refund any actions upon a kill but it should also not disable any other action granting perks should the soldier not score a kill

Reproduction: activate serial and attempt to use any action granting perk while also not scoring a kill

mod list:
lwotc.txt

@wdanny69 wdanny69 added the bug Something isn't working label Feb 3, 2024
@Tedster59
Copy link
Collaborator

There's a lot of things that are explicitly disabled while under Serial, this was an intentional thing. Not sure if we want to change it. Also because of how PostAbilityCostPaid works, basically the first one that returns "true" short circuits it, so you can get a pile of unexpected interactions depending on how each individual effect is set up.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants