Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc Wave has +0 crit damage #1679

Open
copyrite opened this issue Feb 13, 2024 · 3 comments
Open

Arc Wave has +0 crit damage #1679

copyrite opened this issue Feb 13, 2024 · 3 comments
Labels
balance Changes the balance of the game enhancement New feature or request

Comments

@copyrite
Copy link
Collaborator

Arc Wave has +0 crit damage, i.e. crits with Arc Wave deal the same amount of damage as normal hits. It's debatable what the correct behaviour should be:

  • Keep as it is?
  • Give it crit damage?
  • Don't upgrade the hit result?
  • Make it always normal hit?
  • Visualize crits as normal hits?
@Tedster59
Copy link
Collaborator

I'm down to give it proper crit damage if possible.

@copyrite copyrite added enhancement New feature or request balance Changes the balance of the game labels Feb 13, 2024
@RustyDios
Copy link

Is it set at +0 Crit so that other crit damage modifying effects can increase it ... like Amplify ?

@Tedster59
Copy link
Collaborator

I think it's just an artifact of the implementation.

Base game 'X2Effect_ArcWaveMultiDamage' uses a WeaponDamageValue, but only ever sets the Damage part of the struct. LW's version does the same, so net effect is Crit is 0. Easy to change, the question is whether we should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
balance Changes the balance of the game enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants