Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Death from Above only REFUNDS actions and will also only do it when the soldier's turn ends #1695

Open
wdanny69 opened this issue Mar 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@wdanny69
Copy link
Collaborator

Issue: DFA will only refund an action meaning it will not work with abilities such as rapid fire where the bonus shots do not technically cost an action and thus will not refund. This will also only trigger if the soldier's turn ends or do not have actions. This matters in cases like Light Em Up which allows you to fire without ending your turn and will not refund the action.

Proposal: Since this ability is similar to abilities like Hit N Run where it simply grants a single action when the condition is met, I feel like it makes sense to have DFA behave the same as well. This will allow the first issue to trigger as any kill will result in the action granted and the second issue to also work as it grants an action without having to check for the other conditions which don't really make sense in terms of how its described.

modlist:
lwotc.txt

@wdanny69 wdanny69 added the bug Something isn't working label Mar 11, 2024
@Tedster59
Copy link
Collaborator

image

It checks if out of AP, and if the ability had AP beforehand, preventing it from triggering off of free actions. Not sure if there's a better way to get context from the previous stage of abilities without just hardcoding exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants