Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It sounds like that geo-parser miss some out-of-ranges. #22

Closed
Alexandre-T opened this issue May 22, 2024 · 0 comments · Fixed by #23
Closed

It sounds like that geo-parser miss some out-of-ranges. #22

Alexandre-T opened this issue May 22, 2024 · 0 comments · Fixed by #23
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Alexandre-T
Copy link
Contributor

Alexandre-T commented May 22, 2024

It sounds like that geo-parser miss some out-of-ranges.

Geo-Parser SHALL throw range exception with these data :

  • 55°17.60
  • 55:60:32
  • 55:20:60

Two of these new tests fail (just add them in the dataSourceBad provider

public static function dataSourceBad(): \Generator

    yield ['55°60.17\'', RangeException::class, '[RangeException] Minutes must be between 0 and 59, got "55°60.17\'".'];
    yield ['55:60:32', RangeException::class, '[RangeException] Minutes must be between 0 and 59, got "55:60:32".'];
    yield ['55:20:60', RangeException::class, '[RangeException] Seconds must be between 0 and 59, got "55:20:60".'];
@Alexandre-T Alexandre-T added the bug Something isn't working label May 22, 2024
@Alexandre-T Alexandre-T added this to the 3.0.1 milestone May 22, 2024
@Alexandre-T Alexandre-T self-assigned this May 22, 2024
@Alexandre-T Alexandre-T linked a pull request May 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant