Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "random32: add prandom_u32_max and convert open coded users" #67

Open
wants to merge 1 commit into
base: pine64-hacks-1.2
Choose a base branch
from

Conversation

zx2c4
Copy link

@zx2c4 zx2c4 commented Jun 21, 2018

I'm not sure what the deal is with all the various branches you have, but I'd appreciate it if in addition to merging this in whatever random branch I've selected for this PR, you could also cherry-pick it into all the other branches folks are using.


This reverts commit a6cdc1c.

Linux 3.10 does not have this function, because nothing in Linux 3.10
uses it. It was never backported in any of the kernel.org stable trees
to 3.10. Its current inclusion in this pine64 kernel here adds nothing.

The reason this is a problem is because wireguard's compat layer assumes
that 3.10 kernels won't have this function, so having it here actually
causes problems. Sure, we could work around this in wireguard, but it
doesn't seem prudent to play the game of accounting for every possible
frankenkernel out there.

Instead this commit simply reverts the faulty backport.

Signed-off-by: Jason A. Donenfeld [email protected]

This reverts commit a6cdc1c.

Linux 3.10 does not have this function, because nothing in Linux 3.10
uses it. It was never backported in any of the kernel.org stable trees
to 3.10. Its current inclusion in this pine64 kernel here adds nothing.

The reason this is a problem is because wireguard's compat layer assumes
that 3.10 kernels won't have this function, so having it here actually
causes problems. Sure, we could work around this in wireguard, but it
doesn't seem prudent to play the game of accounting for every possible
frankenkernel out there.

Instead this commit simply reverts the faulty backport.

Signed-off-by: Jason A. Donenfeld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant