Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: provide (partial) query metadata to form endpoint as with execute endpoint for validation #545

Open
d1manson opened this issue Sep 15, 2023 · 2 comments

Comments

@d1manson
Copy link

I am trying to build a CRM integration, whereby you sync a list of companies/people from Looker into our CRM (this is a private action hub action).

This requires that the query contains a column corresponding to an id for a company/person. I can validate this at execution time, but it's not a great experience for users as noted in this issue.

So it would be nice if the form endpoint could be used as an opportunity to validate the query in some sense and then return an error (given the form endpoint does support displaying an error message), or if there are multiple possible id columns in the query then provide them in a dropdown select in the form config returned by the endpoint. Currently you don't get so much as a query id on the form endpoint (which might let you hack around this by using other looker api calls of some kind).

Thanks.

@d1manson
Copy link
Author

d1manson commented Oct 3, 2023

The required_fields config should actually cover much of what i had in mind, although it doesn't actually seem to work as far as i can tell with my custom action hub.

I tried it for the Hubspot action, and that seems fine, but when i configure my own action more or less identically to the Hubspot one (based on what i can see in the /integrations endpoint response), it doesn't seem to do anything for me, i.e. the action is shown regardless of which columns are in the query even though the actions list does show "Action can be used with queries that have a field tagged ___" for my action.

Aside from that it would also be handy to still have the original ask here as you could then map columns in the query to fields in the CRM or something

@d1manson
Copy link
Author

d1manson commented Nov 3, 2023

Another use case is if you want to allow users to configure different behaviour for each of the columns in their query, e.g. mapping to a field in a CRM, or handling changes in different ways (e.g. ignore small changes in magnitude, ignore entirely etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant