-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initSdk helper fn in @looker/extension-utils #1000
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7ccdca7
to
b50e8c2
Compare
APIX Tests 1 files 78 suites 3m 15s ⏱️ Results for commit f029e62. |
Typescript Tests 7 files 76 suites 4m 2s ⏱️ Results for commit f029e62. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, but I think you should be able to use IAPIMethods
instead of APIMethods
for the method contract
/** Id used to register this application on the Looker server */ | ||
clientId: string | ||
/** A callback function that returns an sdk instance */ | ||
createSdkCallback: (session: BrowserSession) => APIMethods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this return IAPIMethods
instead? Is there something in APIMethods
that's not documented in IAPIMethods
?
No description provided.