Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initSdk helper fn in @looker/extension-utils #1000

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

josephaxisa
Copy link
Contributor

No description provided.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@josephaxisa josephaxisa force-pushed the jax/ext-utils-sdk-utils branch from 7ccdca7 to b50e8c2 Compare February 21, 2022 17:14
@github-actions
Copy link
Contributor

APIX Tests

    1 files    78 suites   3m 15s ⏱️
313 tests 300 ✔️ 13 💤 0 ❌
329 runs  316 ✔️ 13 💤 0 ❌

Results for commit f029e62.

@github-actions
Copy link
Contributor

Typescript Tests

    7 files    76 suites   4m 2s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
588 runs  572 ✔️ 16 💤 0 ❌

Results for commit f029e62.

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, but I think you should be able to use IAPIMethods instead of APIMethods for the method contract

/** Id used to register this application on the Looker server */
clientId: string
/** A callback function that returns an sdk instance */
createSdkCallback: (session: BrowserSession) => APIMethods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this return IAPIMethods instead? Is there something in APIMethods that's not documented in IAPIMethods?

@josephaxisa josephaxisa requested a review from a team as a code owner March 12, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants