-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show full request url in RunIt response #906
base: main
Are you sure you want to change the base?
Conversation
The Response tab now shows the full request URL, not including the request body (which can't be included in this scenario)
APIX Tests 1 files 77 suites 3m 26s ⏱️ Results for commit 7f48a16. |
Typescript Tests 7 files 76 suites 5m 7s ⏱️ Results for commit 7f48a16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I think it's worth adding a few test cases for ResponseExplorer
packages/run-it/src/RunIt.tsx
Outdated
const [activePathParams, setActivePathParams] = useState({}) | ||
const [activeQueryParams, setActiveQueryParams] = useState({}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: given how tightly coupled path and query params are and that they are always updated together, consider merging these into one state object, activeRequestParams
. Resultant state updates can then happen in one call.
APIX Tests 1 files 77 suites 2m 53s ⏱️ Results for commit de55787. |
Typescript Tests 7 files 76 suites 5m 4s ⏱️ Results for commit de55787. |
APIX Tests 1 files 77 suites 3m 42s ⏱️ For more details on these failures, see this check. Results for commit 7753063. |
Typescript Tests 7 files 76 suites 4m 58s ⏱️ Results for commit 7753063. |
This just got a bit ugly when I was trying to achieve full URL derivation when used as an extension, so this is going to need a little bit of redesign, possibly as part of a RunIt adaptor interface. |
APIX Tests 1 files 77 suites 3m 27s ⏱️ Results for commit efef5e6. |
Typescript Tests 7 files 76 suites 4m 28s ⏱️ Results for commit efef5e6. |
9474788
to
5f9930c
Compare
The Response tab now shows the full request URL, not including the request body (which can't be included in this scenario)
Screenshots