feat: Looker SDK generator for the Dart language #933

bryans99 · 2022-01-08T22:56:01Z

Description:

A generator for the Dart language. Note, only supports Looker SDK 4.0.

Changes:

Dart generator.
Tests for dart generator.
Generated dart methods and models.
Runtime library for dart.
Example dart implementation.
Dart unit tests,
Dart end to end tests.

Description: A generator for the Dart language. Note, only supports Looker SDK 4.0. Changes: 1. Dart generator. 2. Tests for dart generator. 3. Generated dart methods and models. 4. Runtime librart for dart. 5. Example dart implementation. 6. Unit tests, 7. End to end test.

github-actions · 2022-01-08T23:05:11Z

Codegen Tests

    1 files   18 suites 31s ⏱️
422 tests 408 ✔️ 14 💤 0 ❌
423 runs 409 ✔️ 14 💤 0 ❌

Results for commit 6e70e89.

bryans99 · 2022-01-10T01:40:51Z

Converted to draft. google g3 reports a bunch of lint errors. Turned out I had missed turning on full lint. Have figured out how to do that but it will take a while to fix.

github-actions · 2022-01-10T03:49:05Z

Codegen Tests

    1 files   18 suites 26s ⏱️
422 tests 408 ✔️ 14 💤 0 ❌
423 runs 409 ✔️ 14 💤 0 ❌

Results for commit 83309aa.

github-actions · 2022-01-10T05:34:32Z

Codegen Tests

    1 files   18 suites 30s ⏱️
422 tests 408 ✔️ 14 💤 0 ❌
423 runs 409 ✔️ 14 💤 0 ❌

Results for commit 6d68297.

github-actions · 2022-01-10T21:13:52Z

Codegen Tests

    1 files   18 suites 26s ⏱️
422 tests 408 ✔️ 14 💤 0 ❌
423 runs 409 ✔️ 14 💤 0 ❌

Results for commit 108aeef.

jkaster

Looking good. Nothing major but some minor tweaks.

dart/looker_sdk/README.md

jkaster · 2022-01-10T20:47:37Z

dart/looker_sdk/README.md

+
+## Developing
+
+Relies on `yarn` and `dart` being installed. This was developed with `dart` version `2.15.1` so the recommendation is to have a version of dart that is at least at that version.


Do you want to add a Dart install link? Is Dart config supported with Nix? Would be good to find out.

Let me do that.

Not sure I want to get into nix setup for Dart. You cannot use the normal Dart install for cloudtops (you have to download the SDK from an internal google site). Need to figure out how to document "google" specific stuff.

jkaster · 2022-01-10T20:49:22Z

dart/looker_sdk/README.md

+
+### Generate
+
+Run `yarn sdk Gen` from the `{reporoot}`. Note that the SDK generator needs to be built `yarn build`. If changing the generator run 'yarn watch` in a separate window. This command generates two files:


should this be yarn gen dart?

Suggested change

Run `yarn sdk Gen` from the `{reporoot}`. Note that the SDK generator needs to be built `yarn build`. If changing the generator run 'yarn watch` in a separate window. This command generates two files:

Run `yarn gen dart` from the `{reporoot}`. Note that the SDK generator needs to be built with `yarn build` first. If changing the generator run 'yarn watch` in a separate window. This command generates two files:

jkaster · 2022-01-10T20:50:55Z

dart/looker_sdk/README.md

+
+### Run format
+
+Run `yarn format` from `{reporoot}/dart/looker_sdk` to format the `dart` files correctly. This should be run if you change any of the run time library `dart` files. The repo CI will run the linter and will fail if the files have not been correctly formatted.


This can be hooked into the reformatter for codegen

jkaster · 2022-01-10T23:45:42Z

dart/looker_sdk/lib/src/rtl/auth_token.dart

+  AuthAccessToken.fromResponse(Map map, String contentType)
+      : _accessToken = map['access_token'],
+        _tokenType = map['token_type'],
+        _expiresIn = map['expires_in'];


Do you think you'll want the refresh token in case someone wants to implement OAuth flow? Or worry about it then?

Part of the OAUTH flow I think. This is really targeting flutter and an client id/secret will not cut it. Need to get an understanding of how mobile does authentication.

dart/looker_sdk/lib/src/rtl/constants.dart

jkaster · 2022-01-10T23:46:54Z

dart/looker_sdk/lib/src/rtl/sdk.dart

+  static LookerSDK getSdk() {
+    if (_sdk == null) {
+      throw Exception('SDK not initialized');
+    }
+    return _sdk;
+  }


Handy when we only need 1 API supported

jkaster · 2022-01-10T23:48:18Z

dart/looker_sdk/lib/src/rtl/transport.dart

+      case HttpMethod.get:
+        var response = await http.get(fullPath, headers: headers);
+        return handleResponse(response, responseHandler);
+      case HttpMethod.post:
+        var response = await http.post(fullPath, headers: headers, body: body);
+        return handleResponse(response, responseHandler);
+      case HttpMethod.patch:
+        var response = await http.patch(fullPath, headers: headers, body: body);
+        return handleResponse(response, responseHandler);
+      case HttpMethod.delete:
+        var response = await http.delete(fullPath, headers: headers);
+        return handleResponse(response, responseHandler);
+      case HttpMethod.put:
+        var response = await http.put(fullPath, headers: headers, body: body);
+        return handleResponse(response, responseHandler);
+      case HttpMethod.head:
+        throw UnimplementedError('head');
+    }


If you're basing this on what I did for TypeScript, I did it this way because I wasn't clever enough with TypeScript and the request lib to abstract the method and params into a single call

It was based on what you did for typescript and also is original code from way back. This can be improved. Let me do that,

jkaster · 2022-01-10T23:49:51Z

dart/looker_sdk/pubspec.yaml

+name: looker_sdk
+version: 0.0.1
+environment:
+  sdk: '>=2.9.0 <3.0.0'


Curious what this does. Does this mean use 2.9.x or greater but not 3.x?

Again very old stuff. My recollection is that this was mainly driven by flutter but I believe your summation is correct.

@bryans99 would we expect this SDK branch to be the best choice for using looker in flutter mobile apps, or platform calls to swift/kotlin SDKs, or rest api calls, or embedded urls, or just depending on things?

Co-authored-by: John Kaster <[email protected]>

github-actions · 2022-01-12T01:05:45Z

Codegen Tests

    1 files   18 suites 32s ⏱️
422 tests 408 ✔️ 14 💤 0 ❌
423 runs 409 ✔️ 14 💤 0 ❌

Results for commit 9f0a8f4.

neiljaywarner · 2022-06-30T15:11:19Z

@bryans99 i'm interested in this if you have time to get back to it...

bryans99 requested review from jkaster, drstrangelooker, fabio-looker, lanlooker and jeremytchang January 8, 2022 22:56

bryans99 marked this pull request as draft January 10, 2022 01:37

Fixes dart lint issues.

83309aa

bryans99 marked this pull request as ready for review January 10, 2022 03:41

Make it easier to use the SDK in g3 by copying.

6d68297

fix readme

108aeef

jkaster requested changes Jan 10, 2022

View reviewed changes

bryans99 and others added 4 commits January 11, 2022 16:44

Update dart/looker_sdk/README.md

c0028a0

Co-authored-by: John Kaster <[email protected]>

Update dart/looker_sdk/README.md

35f1b83

Co-authored-by: John Kaster <[email protected]>

Update dart/looker_sdk/README.md

a04503b

Co-authored-by: John Kaster <[email protected]>

Update dart/looker_sdk/lib/src/rtl/constants.dart

9f0a8f4

Co-authored-by: John Kaster <[email protected]>

bryans99 marked this pull request as draft January 12, 2022 01:01

drstrangelooker force-pushed the main branch 4 times, most recently from 9474788 to 5f9930c Compare February 4, 2022 02:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Looker SDK generator for the Dart language #933

feat: Looker SDK generator for the Dart language #933

bryans99 commented Jan 8, 2022 •

edited

Loading

github-actions bot commented Jan 8, 2022

bryans99 commented Jan 10, 2022

github-actions bot commented Jan 10, 2022

github-actions bot commented Jan 10, 2022

github-actions bot commented Jan 10, 2022

jkaster left a comment

jkaster Jan 10, 2022

bryans99 Jan 12, 2022

jkaster Jan 10, 2022

jkaster Jan 10, 2022

jkaster Jan 10, 2022

bryans99 Jan 12, 2022

jkaster Jan 10, 2022

jkaster Jan 10, 2022

bryans99 Jan 12, 2022

jkaster Jan 10, 2022

bryans99 Jan 12, 2022

neiljaywarner Jun 30, 2022

github-actions bot commented Jan 12, 2022

neiljaywarner commented Jun 30, 2022


		## Developing

		Relies on `yarn` and `dart` being installed. This was developed with `dart` version `2.15.1` so the recommendation is to have a version of dart that is at least at that version.


		### Generate

		Run `yarn sdk Gen` from the `{reporoot}`. Note that the SDK generator needs to be built `yarn build`. If changing the generator run 'yarn watch` in a separate window. This command generates two files:

	Run `yarn sdk Gen` from the `{reporoot}`. Note that the SDK generator needs to be built `yarn build`. If changing the generator run 'yarn watch` in a separate window. This command generates two files:
	Run `yarn gen dart` from the `{reporoot}`. Note that the SDK generator needs to be built with `yarn build` first. If changing the generator run 'yarn watch` in a separate window. This command generates two files:


		### Run format

		Run `yarn format` from `{reporoot}/dart/looker_sdk` to format the `dart` files correctly. This should be run if you change any of the run time library `dart` files. The repo CI will run the linter and will fail if the files have not been correctly formatted.

feat: Looker SDK generator for the Dart language #933

Are you sure you want to change the base?

feat: Looker SDK generator for the Dart language #933

Conversation

bryans99 commented Jan 8, 2022 • edited Loading

Description:

Changes:

github-actions bot commented Jan 8, 2022

Codegen Tests

bryans99 commented Jan 10, 2022

github-actions bot commented Jan 10, 2022

Codegen Tests

github-actions bot commented Jan 10, 2022

Codegen Tests

github-actions bot commented Jan 10, 2022

Codegen Tests

jkaster left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 12, 2022

Codegen Tests

neiljaywarner commented Jun 30, 2022

bryans99 commented Jan 8, 2022 •

edited

Loading