Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Dpos/Address Mapper to using EIP712 #245

Open
mattkanwisher opened this issue Mar 21, 2019 · 0 comments
Open

Migrate Dpos/Address Mapper to using EIP712 #245

mattkanwisher opened this issue Mar 21, 2019 · 0 comments

Comments

@mattkanwisher
Copy link
Contributor

mattkanwisher commented Mar 21, 2019

    const hash = soliditySha3(
      {
        type: 'address',
        value: from.local.toString().slice(2)
      },
      { type: 'address', value: to.local.toString().slice(2) }
    )
    console.log("addIdentityMappingAsync-hash-", hash)
    const sign = await ethersSigner.signAsync(hash)

Appears we started out with a very similar scheme to eip712. We now need to switch to full standard cause Ethers.js doesn't support eth_personal_sign method except on metamask, so it breaks on things like TrustWallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant