Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove low-level EVM API from Client #54

Open
enlight opened this issue Jun 28, 2018 · 3 comments
Open

Remove low-level EVM API from Client #54

enlight opened this issue Jun 28, 2018 · 3 comments
Assignees
@eduardonunesp
Labels
enhancement New feature or request

Comments

@enlight
Copy link
Contributor

enlight commented Jun 28, 2018

The public Client API has become somewhat bloated with methods that are only used by Loom Provider, Client.getEvmLogsAsync() for example returns a single Uint8Array which end users wouldn't have a clue how to convert into actual log entries (nor should they).
@enlight enlight added the enhancement New feature or request label Jun 28, 2018
@eduardonunesp
Copy link
Contributor

@enlight , Yep those functions are very low level, maybe 99% of users will prefer to use web3 or call JSON RPC to LoomProvider. Maybe we can move those functions to LoomProvider

@eduardonunesp
Copy link
Contributor

Also need to organize the loom.proto separating base from evm, addressmapper and gateway

@eduardonunesp
Copy link
Contributor

PR #199

@eduardonunesp eduardonunesp self-assigned this Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eduardonunesp eduardonunesp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enlight @eduardonunesp