Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix scan mutil refs #29

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: fix scan mutil refs #29

merged 1 commit into from
May 8, 2024

Conversation

loonghao
Copy link
Owner

@loonghao loonghao commented May 8, 2024

No description provided.

@loonghao loonghao force-pushed the improve_api_for_scanner branch 2 times, most recently from ab99f7b to 34366e4 Compare May 8, 2024 16:43
@loonghao loonghao force-pushed the improve_api_for_scanner branch from 34366e4 to 00d1c0e Compare May 8, 2024 16:46
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 70.42%. Comparing base (c91ec8e) to head (00d1c0e).

Files Patch % Lines
maya_umbrella/scanner.py 25.00% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   70.66%   70.42%   -0.24%     
==========================================
  Files          15       15              
  Lines         634      639       +5     
  Branches       70       72       +2     
==========================================
+ Hits          448      450       +2     
- Misses        174      176       +2     
- Partials       12       13       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loonghao loonghao merged commit 1b19ddc into main May 8, 2024
9 checks passed
@loonghao
Copy link
Owner Author

loonghao commented May 9, 2024

@all-contributors please add @Wenfeng-Zhang for tests and code

@loonghao loonghao deleted the improve_api_for_scanner branch May 9, 2024 03:27
Copy link
Contributor

@loonghao

I've put up a pull request to add @Wenfeng-Zhang! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants