Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a larger peer ID #376

Closed
dgllghr opened this issue Jun 5, 2024 · 1 comment
Closed

Consider a larger peer ID #376

dgllghr opened this issue Jun 5, 2024 · 1 comment

Comments

@dgllghr
Copy link

dgllghr commented Jun 5, 2024

Currently the peer ID is limited to a u64. To avoid peer ID collisions with a large number of peers (or needing some kind of central coordination for peer IDs), I would like to use UUIDs as peer IDs. Please consider increasing the size of the peer ID to u128 or [u8; 16].

@zxch3n
Copy link
Member

zxch3n commented Jun 5, 2024

Emm I think by using u64, the possibility of collision for a single CRDT document is low enough. The possibility of collision should be negligible even if there are 1M peers.

@dgllghr dgllghr closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants