feat: add new ways to control commit options #656
+359
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces new methods for setting commit options, origin, and timestamp in the Loro document. The changes include: - Add `set_next_commit_origin` to set the origin for the next commit - Add `set_next_commit_timestamp` to set the timestamp for the next commit - Add `set_next_commit_options` to set custom commit options - Add `clear_next_commit_options` to reset commit options - Update commit methods to handle these new options - Implement corresponding methods in WASM and FFI bindings It also makes the commit options of Undo/Redo controllable
Leeeon233
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces new methods for setting commit options, origin, and timestamp in the Loro document. The changes include:
set_next_commit_originto set the origin for the next commitset_next_commit_timestampto set the timestamp for the next commitset_next_commit_optionsto set custom commit optionsclear_next_commit_optionsto reset commit optionsIt also makes the commit options of Undo/Redo controllable, resolve #654