Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Thresholds #49

Closed
aslmx opened this issue Jul 14, 2021 · 8 comments
Closed

Enhancement: Thresholds #49

aslmx opened this issue Jul 14, 2021 · 8 comments
Labels
feature-request Request for new features to be added

Comments

@aslmx
Copy link

aslmx commented Jul 14, 2021

Thanks for this project!
Its lean and seems to work so far!

What I'd really love to see extended is the notification functionality.

Wouldn't it be nice to have a threshold, for example for Pings, before an Alarm triggers?

my Internet pretty much disconnects every 8-48 hours once for 1-2 minutes.

Would be cool to tell Uptime Kuma to only send a notification if minimum X failed attempts happened.

Thanks for considering!

@Panja0
Copy link

Panja0 commented Jul 14, 2021

We’ve got this covered already in #21

Retries: for instance 3 retries in xx seconds before a service is being marked as down

@aslmx
Copy link
Author

aslmx commented Jul 14, 2021

Thanks for pointing out. Hadn't seen that when looking if it was already mentioned.
(working in QA, my experience is to address each thing in a single ticket/defect/issue, so it is easier to later resolve them one by one, instead of having one mutating issue which never gets closed ;-) - just a suggestion though).

@Panja0
Copy link

Panja0 commented Jul 14, 2021

I get what you mean! Makes sense.
I’ll leave it up to the dev which way he prefers.

Cheers!

@louislam
Copy link
Owner

Thanks for pointing out. Hadn't seen that when looking if it was already mentioned.
(working in QA, my experience is to address each thing in a single ticket/defect/issue, so it is easier to later resolve them one by one, instead of having one mutating issue which never gets closed ;-) - just a suggestion though).

Agree with this, I actually added version number in the frontend which mentioned in #21, but it is hard to mark as resolved.

@Panja0
Copy link

Panja0 commented Jul 15, 2021

@louislam
Ok I understand. What do you suggest?
I can create tickets for all individual request or I can edit my post when something has been resolved. What works best for you?!

@louislam
Copy link
Owner

@louislam
Ok I understand. What do you suggest?
I can create tickets for all individual request or I can edit my post when something has been resolved. What works best for you?!

image

I just discovered that github provides checkbox syntax. Maybe you can prepend a checkbox for each request, so that I can mark as resolved.

@louislam louislam added the feature-request Request for new features to be added label Jul 15, 2021
@Panja0
Copy link

Panja0 commented Jul 15, 2021

@louislam done!

@louislam
Copy link
Owner

Implemented in 1.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

3 participants