Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert/Copy curl of request #5116

Closed
unuchak opened this issue Sep 18, 2024 · 9 comments Β· Fixed by #5152
Closed

Insert/Copy curl of request #5116

unuchak opened this issue Sep 18, 2024 · 9 comments Β· Fixed by #5152
Labels
area:dashboard The main dashboard page where monitors' status are shown area:monitor Everything related to monitors feature-request Request for new features to be added good first issue Good for newcomers hacktoberfest help wanted May need your help to test or answer type:enhance-existing feature wants to enhance existing monitor

Comments

@unuchak
Copy link

unuchak commented Sep 18, 2024

πŸ“‘ I have found these related issues/pull requests

no

🏷️ Feature Request Type

New monitor, Change to existing monitor

πŸ”– Feature description

Add possibility to insert new monitor as curl and add possibility to copy curl of request.

βœ”οΈ Solution

Add possibility to insert new monitor as curl and add possibility to copy curl of request.

❓ Alternatives

No response

πŸ“ Additional Context

No response

@unuchak unuchak added the feature-request Request for new features to be added label Sep 18, 2024
@CommanderStorm
Copy link
Collaborator

Inserting as curl is fairly difficult given the plethora of protocols/crypto-backends/.. that curl supports.
Partial support via parsing of the command would create a different can of worms. I don't think we should touch this at the moment.

Copying the command (and generally better debugging functionality) is something that I would love to see a PR on. => Marking as a good first issue because I think this should be fairly straightforward. I think a good basis would be a debug button next to the safe button which opens a modal (to have a place to put explainaining text) with a copyable text field with the curl command. No backend changes should be nessesary

@CommanderStorm CommanderStorm added help wanted May need your help to test or answer good first issue Good for newcomers hacktoberfest area:monitor Everything related to monitors area:dashboard The main dashboard page where monitors' status are shown type:enhance-existing feature wants to enhance existing monitor labels Sep 22, 2024
@nekojanai
Copy link
Contributor

nekojanai commented Sep 24, 2024

I would like to take this on if possible

  I think a good basis would be a debug button next to the safe button which opens a modal (to have a 
  place to put explainaining text) with a copyable text field with the curl command. No backend 
  changes should be nessesary

I would implement it exactly as described above.
src/components/Confirm.vue
seems to already use some form of modal I would take the template from there and adjust it for this use case.

For DNS I would use something like dig instead since you have to build curl with this capability specifically enabled to make dns requests (I didn't even know curl could do that)

I guess this request only pertains to http requests only?

@CommanderStorm
Copy link
Collaborator

I would implement it exactly as described above.

Thanks, much appreciated. The template to go from seems like a good bet ^^

For DNS I would use something like dig instead

Yea, that would make sense. Have not thought about this.
If you have time for that, that would be awsome (if not, someone else can do this in another PR => loadsharing is a superpower of open source)

@CommanderStorm
Copy link
Collaborator

Our contribution guide (includes how to setup a dev environment) is here. Feel free to ping me if there is anything unclear (being unclear in the docs is a bug too) or you have other questions πŸ˜‰

@Anurag0218
Copy link

is this issue still open? is anyone working on it? If not, can I take it up?

@CommanderStorm
Copy link
Collaborator

Shure, nobody else has commented or provided a PR for this ❀️

@Itachii27
Copy link

Hi @CommanderStorm I want to work on this issue. Kindly assign this to me.

@nekojanai
Copy link
Contributor

nekojanai commented Oct 2, 2024

@Itachii27 @Anurag0218 I'm already working on this?
see #5116 (comment)

@nekojanai
Copy link
Contributor

nekojanai commented Oct 2, 2024

Is there an easy way to update translation strings?
To answer myself: Yes.
https://github.com/louislam/uptime-kuma/blob/b287a25de735d14c6e078d57e99b4587f10697cd/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

language keys need to be added to en.json to be visible in weblate. If this has not happened, a PR is appreciated.

I guess, I'll just add Debug to the en.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard The main dashboard page where monitors' status are shown area:monitor Everything related to monitors feature-request Request for new features to be added good first issue Good for newcomers hacktoberfest help wanted May need your help to test or answer type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants