Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTP compression for uptime check HTTP requests. #5137

Open
flyicn opened this issue Sep 29, 2024 · 1 comment
Open

Enable HTTP compression for uptime check HTTP requests. #5137

flyicn opened this issue Sep 29, 2024 · 1 comment
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added

Comments

@flyicn
Copy link

flyicn commented Sep 29, 2024

πŸ“‘ I have found these related issues/pull requests

can't find any related issue.

🏷️ Feature Request Type

Settings

πŸ”– Feature description

currently, uptimekuma sends http request without "accept-encoding" header.

which means, response is received without compression, in plain text, which can waste bandwidth.
image

βœ”οΈ Solution

Add the "Accept-Encoding: gzip" header to HTTP request headers globally by default, and provide an option to disable it. It would be great to support other compression methods besides gzip(br, zstd)

https://caniuse.com/zstd
https://caniuse.com/?search=brotli

❓ Alternatives

The current workaround is to manually add an HTTP request header for every single monitor, as shown below.

Decompression is done automatically for gzip without modifying uptimekuma (but not for br or zstd).
image
image

πŸ“ Additional Context

No response

@flyicn flyicn added the feature-request Request for new features to be added label Sep 29, 2024
@CommanderStorm
Copy link
Collaborator

zstd and brotli might not be avaliable in the version of node (node 16) that we have currently online in v1.23.x..

Bumping node is a major version bump and thus has to wait for #4500

@CommanderStorm CommanderStorm added the area:monitor Everything related to monitors label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

2 participants