Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell scripts do not work correctly on macOS #22

Open
danhd123 opened this issue Nov 8, 2019 · 2 comments
Open

Shell scripts do not work correctly on macOS #22

danhd123 opened this issue Nov 8, 2019 · 2 comments
Labels
needinfo More information is required before the issue can be adressed

Comments

@danhd123
Copy link

danhd123 commented Nov 8, 2019

While attempting to add Objective-C (NSJSONSerialization) tests, I found that the test scripts do not work correctly on macOS; the output is always 2. The first time I ran it, I got a number of Abort Traps from broken pipes between the scripts:

./utils/binary_search.sh: line 1: 65239 Broken pipe: 13 ./utils/deep_json_array.sh $n 65240 Abort trap: 6 | $json_parsing_command 2> /dev/null > /dev/null
repeated several times with different process numbers, followed by
./utils/binary_search.sh: line 1: 65292 Done ./utils/deep_json_array.sh $n 65293 Abort trap: 6 | $json_parsing_command 2> /dev/null > /dev/null
repeated several times with different process numbers, followed by
2
Subsequent runs just output 2

(Running the tests manually, NSJSONSerialization tops out at 512 levels of nesting.)

macOS 10.14.6, GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin18)

@lovasoa
Copy link
Owner

lovasoa commented Nov 13, 2019

Can you give more details ? The shell script seems to be working the same in MacOS and linux for me.
The Broken pipe [...] Abort trap: 6 messages seem to signal that the underlying program segfaulted. Maybe you can make a pull request with your Objective-C project so that we can have a look at it together ?

@lovasoa
Copy link
Owner

lovasoa commented Nov 13, 2019

I just added swift to the comparison, and the scripts seem to be working fine on the MacOS virtual machines from Travis CI too:
https://travis-ci.org/lovasoa/bad_json_parsers/jobs/611422163

@lovasoa lovasoa added the needinfo More information is required before the issue can be adressed label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo More information is required before the issue can be adressed
Projects
None yet
Development

No branches or pull requests

2 participants