Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hmac,dv] Rare flakiness in hmac_stress_all #23930

Open
gdessouky opened this issue Jul 5, 2024 · 1 comment
Open

[hmac,dv] Rare flakiness in hmac_stress_all #23930

gdessouky opened this issue Jul 5, 2024 · 1 comment
Assignees
Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac

Comments

@gdessouky
Copy link
Contributor

gdessouky commented Jul 5, 2024

Description

hmac_stress_all test fails very rarely for some seeds in a non-reproducible way. It is root-caused to probably be due to when the cfg.wipe_secret_triggered is cleared in https://github.com/lowRISC/opentitan/blob/master/hw/ip/hmac/dv/env/seq_lib/hmac_base_vseq.sv#L211 and how the read digest CSRs are read and compared afterwards. Race conditions may sometimes be occurring between the clearing and reading of the digest CSRs which is the only explanation for the discrepancy between 2 exact logs for 2 exact seeds, where 1 fails and the other passes.

Looking into it and testing out a fix now.

@martin-velay

@gdessouky gdessouky self-assigned this Jul 5, 2024
@gdessouky
Copy link
Contributor Author

This is a minor DV issue, and no RTL is implicated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac
Projects
None yet
Development

No branches or pull requests

1 participant