Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger default behaviour is not graceful #374

Closed
amartyads opened this issue Jan 27, 2025 · 1 comment · Fixed by #379
Closed

Logger default behaviour is not graceful #374

amartyads opened this issue Jan 27, 2025 · 1 comment · Fixed by #379
Assignees

Comments

@amartyads
Copy link
Contributor

Describe the bug
When not including a <loglevel> tag in an input xml, two things are seen in the output:

  1. We get the error from Logger.h, because we pass info in Simulation.cpp and the check is case-sensitive
  2. We get output from all ranks until it's set back to root somewhere inside this function call

To Reproduce
Steps to reproduce the behavior:

  1. Create an xml file without the <loglevel> tag, and run
  2. Check output

Expected behavior
Defaulting to INFO correctly, and regardless, output only being shown on root rank

Build environment (please complete the following information):

  • OS: Linux
  • Compiler: gcc, clang
  • Build System: make
@amartyads amartyads self-assigned this Jan 28, 2025
@HomesGH
Copy link
Contributor

HomesGH commented Jan 30, 2025

This issue was probably introduced with PR #359.
There is another open PR #373 related to the Logger. Maybe we could also fix this issue there, @cniethammer .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants