DM-40265: Add migration script for dimensions-config (v3 to v4) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not tested, but mypy thinks it is OK now.
The optimization for "executemany" that was needed in older SQLAlchemy is no longer needed in 2.0 and default options should work now.
andy-slac
force-pushed
the
tickets/DM-40265
branch
from
6958a13
to
85bd7d5
Compare
timj
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus few updates to existing code to fix issues from new mypy and sqlalchemy versions.
Tested new migration scrip in my local copy of
mainrepo, works fine.Checklist