Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable results redirect servlet for async TAP queries #105

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

stvoutsin
Copy link
Member

Description
PR modifies the Async results functionality, by adding a redirect servlet which serves under /results/*. TAP Async results (jobID/results/result) now link to this servlet (/results/resultID.xml) so that when clients make a (authenticated) request to the results endpoint, they are redirected to the actual file which is stored in a Google CDN location. This should lead the client to strip the auth headers from the request, as otherwise would be a breach of HTTP security best policies.

How was this tested
I've built & deployed a Docker image with this version on idfdev, and tested with the following tools:

  • topcat (async queries fail with newest Topcat, but his is due to a bug which will be fixed by the author)
  • pyvo async queries with CredentialStore authentication)
  • pyvo async queries with AuthSession authentication)

Potential issues
I've only tested this on idfdev, but we have several RSP operators who are storing results in a slightly different way (S3 in openstack for example). Could this break for their environment?

@stvoutsin stvoutsin force-pushed the tickets/DM-44657 branch 2 times, most recently from 17a5db8 to 421622a Compare June 29, 2024 04:23
Copy link
Member

@athornton athornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formal approval. I don't have the Java competence anymore to read this fluently, so I'm going with "sure, looks OK from here."

@stvoutsin stvoutsin merged commit 494b400 into master Jul 2, 2024
2 checks passed
@stvoutsin stvoutsin deleted the tickets/DM-44657 branch July 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants