From c08bcd2c2eb21eeb5bb3da28ca83a93dde8afb8f Mon Sep 17 00:00:00 2001 From: adam Date: Wed, 31 Jul 2024 15:28:43 -0700 Subject: [PATCH] Update commentary in test. --- tests/support/jupyter.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/support/jupyter.py b/tests/support/jupyter.py index 6e6c30a5..f4d70a96 100644 --- a/tests/support/jupyter.py +++ b/tests/support/jupyter.py @@ -249,6 +249,12 @@ def lab_callback(self, request: Request) -> Response: to a callback, and then back to the lab), but it's hopefully good enough to test handling of cookies during redirect chains for capturing the ``_xsrf`` cookie. + + Well...it's not realistic enough, in that the test cases passed but + in practice the ``_xsrf`` cookie would expire. I think that that is + fixed now (similar strategy of following redirects manually and + grabbing the cookie at each intermediate step), but I don't + understand how to test it. """ user = self.get_user(request.headers["Authorization"]) assert str(request.url).endswith(f"/user/{user}/callback")