From 5aaf5ec8df32f9397b1d0f2837b452d7d9a66a59 Mon Sep 17 00:00:00 2001 From: ugyballoons Date: Tue, 3 Sep 2024 15:55:11 +0100 Subject: [PATCH] Tidy up as per PR recommendations --- tests/handlers/external_test.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/handlers/external_test.py b/tests/handlers/external_test.py index 53433cf..99ca9be 100644 --- a/tests/handlers/external_test.py +++ b/tests/handlers/external_test.py @@ -112,7 +112,7 @@ async def test_all_endpoints( all_cams = [f"{summit.name}/{cam.name}" for cam in summit.cameras] online_cams = [f"{summit.name}/{cam.name}" for cam in summit.cameras if cam.online] camera_historical = [f"{cam}/historical" for cam in online_cams] - camera_dates = [f"{cam}/date/{day_obs}" for cam in online_cams if cam] + camera_dates = [f"{cam}/date/{day_obs}" for cam in online_cams] nr_current = [f"{cam}/night_report" for cam in online_cams] nr_dates = [f"{cam}/night_report/{day_obs}" for cam in online_cams] @@ -175,9 +175,6 @@ async def test_request_invalid_dates( res = await client.get(url) assert res.is_error - # TODO: This needs not to be just a success, but a page with a - # 'nothing for this day' message. - # See DM-45327 https://rubinobs.atlassian.net/browse/DM-45327 for url_frag in cam_empty_year: url = f"/{app_name}/{url_frag}" res = await client.get(url)