Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

155 mc phase fit #156

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

155 mc phase fit #156

wants to merge 13 commits into from

Conversation

jrob93
Copy link
Collaborator

@jrob93 jrob93 commented Jul 16, 2024 •
edited
Loading

Fixes #155.

Added a resample flag to PhaseCurve.FitModel. This flag triggers a montecarlo resampling of the observations, using a gaussian distribution centred on the magnitude value and with std equal to the photometric uncertainty. This then returns phase curve parameters with value equal to the mean of the MC distribution, and uncertainties equal to one std of the distribution.

Also includes some small tweaks to ensure PhaseCurve handles units better when they are passed.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@jrob93 jrob93 linked an issue Jul 16, 2024 that may be closed by this pull request
mc phase fit #155
Open
@jrob93
Copy link
Collaborator Author

jrob93 commented Dec 3, 2024

I have merged all recent updates into this old PR. The PhaseCurve FitModel function now has a resample argument, when passed it will resample observations within their (assumed gaussian) uncertainties. Currently there is a basic demo at notebooks/mc_phase_fit_testing.ipynb but I will want to add this to a readthedocs notebook at some point.

I also took the opportunity to add more PhaseCurve unit tests

@jrob93 jrob93 marked this pull request as ready for review December 3, 2024 20:55
@jrob93
Copy link
Collaborator Author

jrob93 commented Jan 3, 2025

I have improved the resample unit tests as requested by @astronomerritt . The tests now also compares the values to some pre-recorded ones.

@jrob93 jrob93 requested a review from astronomerritt January 3, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astronomerritt astronomerritt Awaiting requested review from astronomerritt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mc phase fit
1 participant
@jrob93