DM-41701: Remove deprecated code #362
Merged
+3
−383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-41701
branch
from
78a02c0 to
0ee3643
Compare
parejkoj
approved these changes
Nov 26, 2024
Comment on lines
+22
to
+23
| The first set of measurements uses the SDSS algorithm for centroid and flux | ||
| measurements. |
There was a problem hiding this comment.
I think it's worth expanding this a bit, something like:
Suggested change
| The first set of measurements uses the SDSS algorithm for centroid and flux | |
| measurements. | |
| The first set of measurements uses the SDSS algorithm for centroid and flux | |
| measurements. | |
| This centroid will be used as a fallback, if the below dipole fit fails or if the source does not have a positive and negative peak to attempt a dipole fit to. |
isullivan
force-pushed
the
tickets/DM-41701
branch
2 times, most recently
from
3e06996 to
0783a56
Compare
isullivan
force-pushed
the
tickets/DM-41701
branch
from
0783a56 to
2169487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes NaiveCentroid and badSourceFlags