DM-47901: Configure streak masking for ComCam #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-47901
branch
3 times, most recently
from
ff83967 to
a421749
Compare
mrawls
approved these changes
Dec 11, 2024
| _table = afwTable.SourceTable.make(self.schema) | ||
| self.detection.run(table=_table, exposure=binnedExposure, doSmooth=True) | ||
| sigma = difference.psf.computeShape(difference.psf.getAveragePosition()).getDeterminantRadius() | ||
| _table = afwTable.SourceTable.make(afwTable.SourceTable.makeMinimalSchema()) |
There was a problem hiding this comment.
Do you specifically not want the self.schema we used previously that had some extra columns floating around? I assumed it was more efficient to pass along an existing schema than making a new one from scratch, but it probably doesn't matter much either way.
There was a problem hiding this comment.
The minimal schema is trivial to create, and makes detection slightly faster since the resulting table has far fewer columns.
| self.maskStreaks.maxFitIter = 10 | ||
| # Only mask to 2 sigma in width | ||
| self.maskStreaks.nSigmaMask = 2 | ||
| self.maskStreaks.absMinimumKernelHeight = 2 |
There was a problem hiding this comment.
Please add docstring for the absMinimumKernelHeight config setting
isullivan
force-pushed
the
tickets/DM-47901
branch
from
a421749 to
144aacb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.