Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40198 Allow parameters to be used in Python/config block #359

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

natelust
Copy link
Contributor

Allow parameters defined in a Pipeline to be used withing a python config block, or a loaded config file.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@natelust natelust force-pushed the tickets/DM-40198 branch 2 times, most recently from 408909c to ade2088 Compare July 28, 2023 14:12
doc/changes/DM-40198.feature.md Outdated Show resolved Hide resolved
python/lsst/pipe/base/configOverrides.py Outdated Show resolved Hide resolved
python/lsst/pipe/base/configOverrides.py Outdated Show resolved Hide resolved
tests/test_configOverrides.py Outdated Show resolved Hide resolved
Allow parameters defined in a Pipeline to be used withing a python
config block, or a loaded config file.
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 98.11% and project coverage change: +0.11% 🎉

Comparison is base (e810ed9) 82.81% compared to head (605ceea) 82.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   82.81%   82.92%   +0.11%     
==========================================
  Files          66       66              
  Lines        7255     7299      +44     
  Branches     1418     1424       +6     
==========================================
+ Hits         6008     6053      +45     
+ Misses       1000      998       -2     
- Partials      247      248       +1     
Files Changed Coverage Δ
python/lsst/pipe/base/configOverrides.py 92.92% <96.77%> (+5.14%) ⬆️
python/lsst/pipe/base/config.py 70.51% <100.00%> (+0.38%) ⬆️
python/lsst/pipe/base/pipelineIR.py 85.35% <100.00%> (ø)
tests/test_configOverrides.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@natelust natelust merged commit 548ec45 into main Jul 28, 2023
14 checks passed
@natelust natelust deleted the tickets/DM-40198 branch July 28, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants