Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage pattern of AnnotatedPartialOutputsError #439

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

kfindeisen
Copy link
Member

This PR tweaks the class docstring for AnnotatedPartialOutputsError to emphasize that it does not follow the usual usage pattern for exceptions.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (be41127) to head (bdf3aee).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files          96       96           
  Lines       10931    10931           
  Branches     2086     2086           
=======================================
  Hits         8875     8875           
  Misses       1698     1698           
  Partials      358      358           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a useful note. I just wish the docstring for annotate were available here!

This directs users to the annotate method for more details if the
documentation is built correctly, and serves as a backup to the method
docs if it's not.
@kfindeisen kfindeisen merged commit b9c5a67 into main Aug 28, 2024
13 checks passed
@kfindeisen kfindeisen deleted the u/kfindeisen/annotate-doc branch August 28, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants