Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error running Scheduler_intro notebook in lsst/rubin_sim_notebooks #383

Closed
susmitastro opened this issue Nov 24, 2023 · 1 comment
Closed

Comments

@susmitastro
Copy link

Hello,

I am trying to run lsst/rubin_sim_notebooks/scheduler/1-Scheduler_intro.ipynb to generate a list of observations and then schedule the simulated observations.

The generation of the list of observations is done in the following way:

class MySurvey(BaseSurvey):
   def generate_observations_rough(self, conditions):
       obs = empty_observation()
       obs['RA'] = np.radians(273.0)
       obs['dec'] = np.radians(-78.0)
       #obs['RA'] = 0
       #obs['dec'] = np.radians(-87)
       obs['exptime'] = 30.  # Seconds
       obs['nexp'] = 2
       obs['filter'] = 'r'
       # If it's been 12 hours or more, don't try to execute the observation anymore
       obs['flush_by_mjd'] = conditions.mjd + 1
       obs['note'] = 'mysurvey'  # Always good to set the note to which survey generated the observation
       # Make it a list of n
       result = [obs] * 7
       return result
       #print(empty_observation)

The simulated observations are scheduled using the following:

# Now to build our scheduler object, and run it for a day
scheduler = CoreScheduler([my_survey], nside=nside)
# sim_runner will return the updated model observatory, the updated scheduler, and an array of
# completed observations
mo, scheduler, observations = sim_runner(mo, scheduler,survey_length=1,
                                                verbose=True)

When the notebook is ran for the default RA and DEC given in the tutorial, it seems to be working fine. However, if the RA and DEC are changed to a different coordinates (described below) it seems to run into problems.

There are two different issues when the RA and DEC are changed:

The notebook runs perfectly fine when the RA is 228 deg or more and DEC is < -77, but seems to break once the RA and DEC are outside these limits.
Secondly, at times for some of the values of the RA and DEC that are within the above mentioned limits seems to not work for the notebook. For example:

Run 1: RA 360 DEC -77 works fine
Run 2: RA 350 DEC -77 works fine
Run 3: RA 360 DEC -77 doesnt work

The block above produces the following error:

RuntimeError                              Traceback (most recent call last)
[scheduler.ipynb](about:blank) Cell 10 line 7
      2 scheduler = CoreScheduler([my_survey], nside=nside)
      3 # sim_runner will return the updated model observatory, the updated scheduler, and an array of
      4 # completed observations
----> 7 mo, scheduler, observations = sim_runner(mo, scheduler,survey_length=1,
      8                                                  verbose=True)

File[ ~/.conda/envs/rubin-sim/lib/python3.11/site-packages/rubin_sim/scheduler/sim_runner.py:105](about:blank), in sim_runner(observatory, scheduler, filter_scheduler, mjd_start, survey_length, filename, delete_past, n_visit_limit, step_none, verbose, extra_info, event_table, record_rewards)
    102 if observatory.mjd == mjd_last_flush:
    103     #sush
    104     print(mjd_last_flush)
-->[ 105](about:blank)     raise RuntimeError("Scheduler has failed to provide a valid observation multiple times.")
    106 # if this is a first offence, might just be that targets set. Flush queue and get some new targets.
    107 scheduler.flush_queue()

RuntimeError: Scheduler has failed to provide a valid observation multiple times

I am running these in rubin_sim version 1.3.3 and with opsim baseline v3.3_10yrs
I was wondering if someone will be able to help me with this issue.

@rhiannonlynne
Copy link
Member

Answered in rubin_sim_notebooks lsst/rubin_sim_notebooks#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants