Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] RTL: set RTL per screen or new modes per screen #39

Open
lubeda opened this issue Jun 9, 2023 · 6 comments
Open

[FEATURE REQUEST] RTL: set RTL per screen or new modes per screen #39

lubeda opened this issue Jun 9, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lubeda
Copy link
Owner

lubeda commented Jun 9, 2023

@idodov

@lubeda lubeda added enhancement New feature or request help wanted Extra attention is needed labels Jun 9, 2023
@lubeda lubeda changed the title [FEATURE REQUEST] RTL set RTL per screen or new modes per screen [FEATURE REQUEST] **RTL:** set RTL per screen or new modes per screen Jun 9, 2023
@lubeda lubeda changed the title [FEATURE REQUEST] **RTL:** set RTL per screen or new modes per screen [FEATURE REQUEST] RTL: set RTL per screen or new modes per screen Jun 9, 2023
@lubeda
Copy link
Owner Author

lubeda commented Jun 9, 2023

I don't want to add another parameter to the default service cal because there are already plenty of parameters. But new modes/service calls for RTL seem possible.

@idodov
Copy link

idodov commented Jun 9, 2023

It can be a boolean parameter like default font in the service. Adding that would be awesome.

@idodov
Copy link

idodov commented Nov 19, 2023

Feel free to explore how I addressed the RTL language display issue on the provided GitHub link: https://github.com/idodov/bidi
If you find the solution helpful, consider adding it to the wiki section.

@lubeda
Copy link
Owner Author

lubeda commented Nov 20, 2023

Hi, i can't test but i added a wiki page. Hope it helps

@idodov
Copy link

idodov commented Dec 9, 2023

You might also be interested in another feature I have that allows album art to be displayed as icons.
https://github.com/idodov/LedMatrixAlbumArt

@ofirsnb
Copy link

ofirsnb commented Dec 13, 2023

Idodov, very nice idea of the LedMatrixAlbumArt, thanks for sharing:)

Also thank you Lubeda and Andrew of course, I know you've been looking for a solution for this FR and similar cases.

I myself, using a lot of both Heb+Eng strings for different scenarios,
and an option to allow setting RTL per screen would be super helpful and appreciated! 🙏

As far as I know too, unfortunately, we can't use optionals in the ESPHome service-calls, so I understand the hesitation,
but may I suggest a middle-ground solution?
Can we have an option, to set the rtl flag per default_font and special_font (or even just for special_font)?
Something like:

ehmtxv2:
  id: rgb8x32
  default_font_id: ehmtx_font
  special_font_id: ehmtx_font_heb
  special_font_rtl: true  # default will be `false`

That way, anytime we select the special_font using the current service-calls, it will render with RTL.

I think this solution will be most suitable considering the current limitations, and doesn't break any current usages.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants