Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling skip_screen repeatedly brings back deleted screens #59

Open
dbuezas opened this issue Jul 12, 2023 · 3 comments
Open

Calling skip_screen repeatedly brings back deleted screens #59

dbuezas opened this issue Jul 12, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@dbuezas
Copy link
Contributor

dbuezas commented Jul 12, 2023

Bug report

Calling skip_screen repeatedly brings back deleted screens

Describe the bug

By adding id(rgb8x32)->skip_screen(); to the on_press of the right button, I can call it in rapid succession.
It looks like doing it more than once before there is an automatic screen change makes it pick up broken/deleted screens.

@dbuezas dbuezas added the bug Something isn't working label Jul 12, 2023
@dbuezas
Copy link
Contributor Author

dbuezas commented Jul 12, 2023

Looking at the logs, I see "tick: nothing to do. Restarting clock display", and I am deleting those so this seems to be the problem. I would expect it to just jump to the front of the circular queue.
Interestingly, the unexpectedly added clock screens have the wrong y offset (I'm using 10 since I have a full height font)

allow_empty_screen: true avoids the issue by just showing a blank screen

@lubeda
Copy link
Owner

lubeda commented Jul 13, 2023

Why don't you provide a pull request based on the develop-branch?

@dbuezas
Copy link
Contributor Author

dbuezas commented Jul 13, 2023

I'll give it a try when I have some time.
Thanks for this cool project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants