Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

River is considered as a snowy biome? #207

Open
HLHTHoldWind opened this issue Sep 29, 2024 · 5 comments
Open

River is considered as a snowy biome? #207

HLHTHoldWind opened this issue Sep 29, 2024 · 5 comments

Comments

@HLHTHoldWind
Copy link

The river in the savanna will snow even in the summer after toggle option "shouldSnowyBiomesMeltInSummer" to "false".

Is river incorrectly considered as a snowy biome?

(The snowflakes on the bottom of the screen)
2024-09-30_03 34 44

(Current season is summer)
image

@MTaningco
Copy link
Contributor

MTaningco commented Sep 29, 2024

Hmm... the river biome is not considered a snowy biome. So, it is strange you are getting this behavior. Do you have a mod that changes the biomes generated? What is your entire mod list? What does the rest of your config look like? Are you on a single player world? Does your F3 screen show the current biome you are in as well as how many days into the world you are? Did this only start happening with the recent beta release of Fabric Seasons? And does this actually produce and sustain ice?

@HLHTHoldWind
Copy link
Author

Hmm... the river biome is not considered a snowy biome. So, it is strange you are getting this behavior. Do you have a mod that changes the biomes generated? What is your entire mod list? What does the rest of your config look like? Are you on a single player world? Does your F3 screen show the current biome you are in as well as how many days into the world you are? Did this only start happening with the recent beta release of Fabric Seasons? And does this actually produce and sustain ice?

Mod list:
image

Config:
{
"seasonLength": {
"springLength": 1824000,
"summerLength": 2568000,
"fallLength": 1824000,
"winterLength": 2544000
},
"seasonLock": {
"isSeasonLocked": false,
"lockedSeason": "SPRING"
},
"dimensionAllowlist": [
"minecraft:overworld"
],
"doTemperatureChanges": true,
"shouldSnowReplaceVegetation": true,
"shouldSnowyBiomesMeltInSummer": false,
"shouldIceNearWaterMelt": false,
"shouldIceBreakSugarCane": false,
"biomeDenylist": [
"terralith:glacial_chasm",
"minecraft:frozen_ocean",
"minecraft:deep_frozen_ocean",
"minecraft:cold_ocean",
"minecraft:deep_cold_ocean",
"minecraft:ocean",
"minecraft:deep_ocean",
"minecraft:lukewarm_ocean",
"minecraft:deep_lukewarm_ocean",
"minecraft:warm_ocean"
],
"biomeForceSnowInWinterList": [
"minecraft:plains",
"minecraft:sunflower_plains",
"minecraft:stony_peaks"
],
"isSeasonTiedWithSystemTime": false,
"isInNorthHemisphere": true,
"isFallAndSpringReversed": false,
"isSeasonMessingCrops": true,
"isSeasonMessingBonemeal": false,
"doCropsGrowsNormallyUnderground": false,
"doAnimalsBreedInWinter": true,
"notifyCompat": true,
"debugCommandEnabled": false
}

Playing Online

Biome:
image

I'm using the latest version 2.4.1-BETA

It produce ice
2024-09-30_04 06 51

And melt in the spring
2024-09-30_04 07 10

@HLHTHoldWind
Copy link
Author

As you can see in the background, the river still snow in the summer
2024-09-30_04 15 24

@HLHTHoldWind
Copy link
Author

I may find where the problem is.
The river snow effect out of the winter is just a visual effect, it will not produce ice out of the winter.

For some reason, the client will not update the river season immediately when playing on the server. So you will see the river is snowing even the winter already passed.
It takes time to update to the correct river season. After client updated, river will rain instead of snow.

(but other biomes' season will update on the client as soon as they can)

@HLHTHoldWind
Copy link
Author

HLHTHoldWind commented Sep 29, 2024

I suggest there should be an improvement: The river near a hot biome should not snow in any season.

A snowing savanna/desert river (even in the winter) really looks weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants