Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow Not Melting Outside of Winter #211

Open
tennisshoesfan opened this issue Oct 9, 2024 · 15 comments
Open

Snow Not Melting Outside of Winter #211

tennisshoesfan opened this issue Oct 9, 2024 · 15 comments

Comments

@tennisshoesfan
Copy link

Running the latest version on a 1.21.1 modded server, and snow is not melting. The ice melts fine after changing the shouldIceNearWaterMelt to true in the config file, but snow doesn't melt at all. Attached are screenshots, as well as the modlist on our server and the config file.
2024-10-08_17 51 42
2024-10-08_17 51 49
2024-10-08_17 52 03
Screenshot 2024-10-08 180708
Screenshot 2024-10-08 180849

@MTaningco
Copy link
Contributor

Can you describe some context of your server?

  • is it only the plains biome affected?
  • was this mod only recently added? or has it been active for the past 474 days according to your screenshots?
  • does your server have server specific configs (outside of fabric seasons) that may disable snow melting?

@tennisshoesfan
Copy link
Author

It's all biomes that receive snow in the winter, not just the plains. The mod has been active for the whole life of the server. The only potential conflict I can see in the other config files is the Realistic Sleep mod, which have some settings that look like they do some tick manipulation related to ice and snow. I just found those and was going to play around with them this weekend to see if that affects anything.

@MTaningco
Copy link
Contributor

As of current, it's not quite obvious as to why this issue exists. One way to diagnose this is to create a temporary/local server and start with fabric seasons. If this causes the bug, then it's definitely fabric seasons. Build up your modlist slowly and test your server adding one mod at a time. Eventually you will find the bug and we can pin point what exactly is wrong.

@ViciousBadger
Copy link

ViciousBadger commented Oct 21, 2024

Exact same issue here, but we don't have and mods in common that I would think was an obvious suspect.. We use BetterDays, might be a possible cause, could try to disable it.. or maybe it's Unloaded Activity..? Will report back if I find anything

Update: it's not Unloaded Activity, BetterDays, Rain Grow, ModernFix or Lithium.. that much is for sure..

@blueberry-bytes
Copy link

I have similar problem. One day of early spring everything just stopped melting. It may be the moment I switched from Quilt to Fabric but I'm not sure, it doesn't have to be. Next winter everything got white and next spring only new white blocks melted while the ones from before stayed white. How can I unfreeze like a million blocks now? I'm no Eskimo.
image

@MTaningco
Copy link
Contributor

Based on new info from other people, I have a feeling that this issue happens when there is vegetation that is replaced with snow over the snowing seasons, and then perhaps the server was updated to 1.21.x. The pictures available so far suggest that there are still some blocks that do melt the snow. So for those having the issue:

  • was there a recent server world update that led to this starting to happen?
  • are there still at least a few blocks that melt snow in the problematic chunks?
  • when there's precipitation, do the problematic chunks have the snow or rain animation?

@blueberry-bytes
Copy link

I started on 1.21.1, it's a new server. It was the first winter. It started melting on spring and then it stopped. I know that I switched from Quilt to Fabric (because of a few other mods that didn't work on old fabric-loader that was in Quilt 1.21) but I don't remember if that was the same moment.
During that first winter I was walking through the island, that's why big part is white. When it started melting I was only around my house, that's why there's a circle with some green on it. In the middle of it there's pure green, it was done by hand, during leveling terrain.
There was definitely snow animation when all this turned white.
The second winter came, again everything turned white during snowfall, but by summer only blocks that had been previously green turned back green.

I've solved it a little. I used a command to turn ice to water. Had to repeat it a few times, because of the fill limit.
/fill ~-90 62 ~-90 ~90 62 ~90 minecraft:water replace minecraft:ice
With snow it's harder, because it's on different levels and therefore the square has to be much smaller every time.
If I manage to clean it before third winter, I'll know if it was just a one time thing.

@MTaningco
Copy link
Contributor

If anything you can clean up just a strip so that we can compare the cleaned up area, the problematic chunks that isn't cleaned up, and newly generated chunks and let the winter pass. If by summer, the snow is still present and there is still snow animation, that helps pin down the problem a bit better. Do update this thread! @blueberry-bytes
image

@blueberry-bytes
Copy link

Sorry, but I had already cleaned up everything. Wife's orders.
First I modified rule
/gamerule commandModificationBlockLimit 999999999
Then I used similar command, several times in different places:
/fill ~-90 ~-10 ~-90 ~90 ~30 ~90 minecraft:air replace minecraft:snow

@ViciousBadger
Copy link

So in my weird case, turns out snow doesn't even fall in winter! It was all the work of Unloaded Activity, 'spawning' snow as soon as chunks were loaded..

I'm pretty sure random ticks are turned on and there is snow particles in the air indicating to me that snow should land, but it just doesnt. very strange

@MTaningco
Copy link
Contributor

I'm pretty sure random ticks are turned on and there is snow particles in the air indicating to me that snow should land, but it just doesnt. very strange

afaik, something similar happens when your client has the mod but not the server. the client calculates that it should snow which then has the snow preciptation animation, but ofc the server won't spawn a snow layer because it doesn't have the mod. Might be related

@ViciousBadger
Copy link

I'm pretty sure random ticks are turned on and there is snow particles in the air indicating to me that snow should land, but it just doesnt. very strange

afaik, something similar happens when your client has the mod but not the server. the client calculates that it should snow which then has the snow preciptation animation, but ofc the server won't spawn a snow layer because it doesn't have the mod. Might be related

I'm 100% sure the mod is active on the server. Ice melting in warm seasons works as intended when turned on, and also for some reason snow melts properly in newly generated 'cold' biomes.. just not on old terrain.

It's more likely that some mixin is being messed up by another mod unfortunately.

@blueberry-bytes
Copy link

The same thing happened. During winter everything went white and now it's half of the summer and only like 20% of snow and 2% of ice have melted.
image

@Eggnoggg
Copy link

Any update on this? Currently still having this issue as of version 2.4.2 for Minecraft version 1.21.1 . Running a different set of mods than what is listed above, can provide those if needed.

@GoatedGoat23
Copy link

Hey guys, I figuered something out on an older Version, but I suspect it might be the same Issue.

I also had a Modded server, where after the first Winter the Snow would not melt. I experimentet a bit and found out, that it was due to a line in the "SnowBlockMixin.java"-File of the Mod. It was Minecraft 1.19.1 I believe.

In line 26 the Code checks if a given Snow-Block is meltable, and therefore determines if It should melt in Spring. One of the Parameters given is a true/false Value, that basically indicates if the Block was placed Manually.

WHAT I SUSPECT HAPPENED (Not 100% Sure, fixed the Issue for me though);
Blocks are not supposed to melt when they have been placed by a Player (Maybe config Option?), and I think that somehow the Manual Placement check switches to true due to certain (Mod-) interactions. (For me it was a mod adding Snow stacking, which marked the newly placed multi Layered Snow as Player-Placed).

Removing the check for Player-placed Snow fixed it for me and snow would always melt again.
Obviously now Snow you place also melts, but I find that to be a worthwhile sacrifice.

I dont know about Snow not landing when it is Snowing though, just thought my "Fix" was related.
There is a screenshot of the Code attached.

PS:
To try it yourself you have to clone/Open the mod directory (.jar) to access its files, change the 1 line of Code in "SnowBlockMixin.java" (See Screenshot) and rebuild the Jar. (Watch some tutorial on Youtube, might need a program for that).

Snow not Melting Screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants