Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items missing from EMI search #212

Open
aagui5 opened this issue Jul 23, 2023 · 8 comments
Open

Items missing from EMI search #212

aagui5 opened this issue Jul 23, 2023 · 8 comments

Comments

@aagui5
Copy link

aagui5 commented Jul 23, 2023

Many items are missing from EMI search, but still exist in the creative inventory and can still be crafted. Affects versions kibe-1.9.10+ for MC 1.19.2

The issue is not present in kibe-1.9.9-BETA+1.19

Steps to reproduce:

  1. Install kibe-1.9.10+ (any version above 1.9.9)
  2. Install latest version of EMI
  3. In-game, search keyword "@kibe", should see that many items are missing from search query, but still present in the creative inventory.
@Bluetinity
Copy link

The items are also missing in vanilla creative inventory search, and can only be found in the kibe creative inv tab.

@Kisuny
Copy link

Kisuny commented Nov 22, 2023

same problem
image

@RemagOfficial
Copy link

in most cases on REI is supported

@Kisuny
Copy link

Kisuny commented Nov 22, 2023

in most cases on REI is supported

yes but emilyploszaj/emi#227

@RemagOfficial
Copy link

RemagOfficial commented Nov 22, 2023

in most cases on REI is supported

yes but emilyploszaj/emi#227

but what, thats EMI not REI

@Slayer5934
Copy link

Slayer5934 commented Nov 23, 2023

https://github.com/lucaargolo/kibe/blob/1.19/src/main/kotlin/io/github/lucaargolo/kibe/blocks/BlockCompendium.kt

The blocks are not specifically registered here, that is likely why it is not showing for EMI or creative search..

@Ristovski
Copy link

@RemagOfficial

in most cases on REI is supported

yes but emilyploszaj/emi#227

but what, thats EMI not REI

If you were to read the comments in that issue, you would see that the real problem has nothing to do with EMI itself:

This is an issue because Kibe registers about half of its items in creative tabs but not the other half. EMI's metric for if a mod needs to have all of its items show up is if it only puts a small amount of them into creative tabs. I believe Kibe needs to resolve this by properly handling creative tabs.

This means that if Kibe was properly registering all items in creative tabs, they would not only show up on vanilla but EMI would be supported out of the box as well.

I assume REI simply shows all registered items instead, and currently Kibe seems to rely on this.

@Kisuny
Copy link

Kisuny commented Dec 4, 2023

EMI author fix problem

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants