Fix broken block parsing when label prefix contains dots #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
CADDY_DOCKER_LABEL_PREFIX
contains dots, parsing of blocks will break.e.g. With
CADDY_DOCKER_LABEL_PREFIX=mydomain.gitlab.caddy
, cdp will yield error:Then wrongly parsed block is:
It is because
gitlab.caddy
inmydomain.gitlab.caddy
also gets parsed as path.Using dots in prefix conforms to what docker has adopted in their labels, e.g.:
So using dot-separated string in
CADDY_DOCKER_LABEL_PREFIX
should be a good way to keep naming style consistent with other labels and should be supported.This PR fixes it by canonicalizing the label prefix to
"caddy"
, so meta characters in user provided label prefix will not affect cdp's block parsing.